[SSH] Update error message for OpenSSH version incompatility#9777
[SSH] Update error message for OpenSSH version incompatility#9777vthiebaut10 wants to merge 1 commit intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @vthiebaut10, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the OpenSSH version incompatibility warning to reference official OpenSSH release notes instead of a Bugzilla discussion.
Changes:
- Replaced the Bugzilla link with a link to OpenSSH 8.8 release notes (“Potentially-incompatible changes”) in two warning messages.
| logger.warning("The OpenSSH server version in the target VM %d.%d is too old. " | ||
| "Version incompatible with OpenSSH client version %d.%d. " | ||
| "Refer to https://bugzilla.mindrot.org/show_bug.cgi?id=3351 for more information.", | ||
| "Refer to \"Potentially-incompatible changes\" in " | ||
| "https://www.openssh.org/txt/release-8.8 for more information.", | ||
| remote_major, remote_minor, local_major, local_minor) |
There was a problem hiding this comment.
The same reference text/URL is duplicated across both warnings. To reduce drift and make future updates easier, store the reference (section text + URL) in a single constant (or local variable) and reuse it in both logger.warning calls.
| logger.warning("The OpenSSH client version %d.%d is too old. " | ||
| "Version incompatible with OpenSSH server version %d.%d in the target VM. " | ||
| "Refer to https://bugzilla.mindrot.org/show_bug.cgi?id=3351 for more information.", | ||
| "Refer to \"Potentially-incompatible changes\" in " | ||
| "https://www.openssh.org/txt/release-8.8 for more information.", | ||
| local_major, local_minor, remote_major, remote_minor) |
There was a problem hiding this comment.
The same reference text/URL is duplicated across both warnings. To reduce drift and make future updates easier, store the reference (section text + URL) in a single constant (or local variable) and reuse it in both logger.warning calls.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @vthiebaut10 Release SuggestionsModule: ssh
Notes
|
Error message should link to official OpenSSH Release Notes instead of bugzilla discussion.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.